[
https://issues.apache.org/jira/browse/HDFS-4909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971870#comment-13971870
]
Hadoop QA commented on HDFS-4909:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12640497/HDFS-4909.001.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6676//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6676//console
This message is automatically generated.
> Protocol buffer support compiles under C, but fails to link due to duplicate
> symbols
> ------------------------------------------------------------------------------------
>
> Key: HDFS-4909
> URL: https://issues.apache.org/jira/browse/HDFS-4909
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode, journal-node, namenode
> Affects Versions: 3.0.0, 2.1.0-beta
> Reporter: Ralph Castain
> Assignee: Colin Patrick McCabe
> Priority: Blocker
> Attachments: HDFS-4909.001.patch, HDFS-4909.002.patch, pcreate.pl
>
>
> The revised protocol buffer support seems to be compiling for me when using
> the protobuf-c cross-compiler. However, I still cannot construct a library of
> the results. This may be a Hadoop issue, or could be an issue with the
> protobuf-c cross-compiler. What I see are a bunch of these when attempting to
> link the resulting .o files:
> /home/common/hadoop/hadoop-common/foo/obj/DatanodeProtocol.pb-c.o: In
> function `hadoop_hdfsreport_bad_blocks_request_proto_init':
> DatanodeProtocol.pb-c.c.text+0x2bb4): multiple definition of
> `hadoop_hdfsreport_bad_blocks_request_proto_init'
> /home/common/hadoop/hadoop-common/foo/obj/ClientNamenodeProtocol.pb-c.o:ClientNamenodeProtocol.pb-c.c.text+0x277d):
> first defined here
> From what I can see, this is caused by the
> package hadoop.hdfs;
> line in the .proto files, when combined with the later
> import "hdfs.proto";
> This appears to bring a complete copy of the hdfs.proto file into the source
> code, which then recompiles it - leading to the duplicate symbols.
> I have attached an updated pcreate.pl script that illustrates the problem.
> Excluding the following .proto files allows all to be successfully built and
> linked:
> DatanodeProtocol
> ClientNamenodeProtocol
> QJournalProtocol
> HTH
> Ralph
--
This message was sent by Atlassian JIRA
(v6.2#6252)
