[ 
https://issues.apache.org/jira/browse/HDFS-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aaron T. Myers updated HDFS-6281:
---------------------------------

    Attachment: HDFS-6281.patch

Thanks a lot for the review, gents. Attached patch addresses both of your 
review comments.

Additionally, Charlie pointed out offline that the closing of the privileged 
socket should be done in the {{destroy()}} method, not the {{close()}} method. 
I don't actually think it matters from a functional perspective in our case, 
since we're not running this daemon in any sort of container so {{stop()}} 
should only be called once, but according to the Commons Daemon javadoc, the 
proper place to free resources is in destroy():

https://people.apache.org/~mturk/daemon-1.0.15-site/apidocs/org/apache/commons/daemon/Daemon.html

So, this patch makes that change as well.

And yes, I agree - the two previous test failures were almost certainly 
spurious.

> Provide option to use the NFS Gateway without having to use the Hadoop 
> portmapper
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-6281
>                 URL: https://issues.apache.org/jira/browse/HDFS-6281
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: nfs
>    Affects Versions: 2.4.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>         Attachments: HDFS-6281.patch, HDFS-6281.patch
>
>
> In order to use the NFS Gateway on operating systems with the rpcbind 
> privileged registration bug, we currently require users to shut down and 
> discontinue use of the system-provided portmap daemon, and instead use the 
> portmap daemon provided by Hadoop. Alternately, we can work around this bug 
> if we tweak the NFS Gateway to perform its port registration from a 
> privileged port, and still let users use the system portmap daemon.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to