[
https://issues.apache.org/jira/browse/HDFS-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13984238#comment-13984238
]
Charles Lamb commented on HDFS-6295:
------------------------------------
Hi Andrew,
I have a few nits, but in general this looks good.
DatanodeManager.java:
There are finals for isDead and isDecommissioning as well as xxxNodes above.
Since you've added listDecommissioningNodes, why not make all of the
listFooNodes decls also have finals (for consistency)?
DFSAdmin.java:
In report():
consider 'final' for boolean listFoo decls.
s/) :/): /g
In the listDecommissioning decl/assignment, I think you're using 4 space
indentation rather than 2. Ditto for the "decom" decl.
There's an extra newline before the closing } of that method that appears to be
added by your patch.
In printHelp,
consider final decls (although I realize this would extend the diffs beyond
what the patch is really about so you'll probably skip this one).
s/report ="/report = "/ (i.e. add a space after the = and before the ")
I had trouble parsing the second sentence (maybe I just need some coffee).
Perhaps,
s/Specifying additional flags filters the displayed list of DNs./Optional flags
may be used to filter the list of DNs./
TestDecommissioningStatus.java:
The baos decl needs to be indented 2 spaces.
Consider finals for these decls.
> Add "decommissioning" state and node state filtering to dfsadmin
> ----------------------------------------------------------------
>
> Key: HDFS-6295
> URL: https://issues.apache.org/jira/browse/HDFS-6295
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.4.0
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-6295-1.patch
>
>
> One of the few admin-friendly ways of viewing the list of decommissioning
> nodes is via "hdfs dfsadmin -report". However, this lists *all* the datanodes
> on the cluster, which is prohibitive for large clusters, and also requires
> manual parsing to look at the decom status. It'd be nicer if we could fetch
> and display only decommissioning nodes (or just live and dead nodes for that
> matter).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
