[ 
https://issues.apache.org/jira/browse/HDFS-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985550#comment-13985550
 ] 

Uma Maheswara Rao G commented on HDFS-6302:
-------------------------------------------

Thanks Yi for the update on the patch!
Patch almost looks good to me. I have few nits left to handle.

1) You should have covered removeXattrFeature also in the test
2) Produce brief javadoc for *xattrfeature apis in INode.

> Implement XAttr as a INode feature.
> -----------------------------------
>
>                 Key: HDFS-6302
>                 URL: https://issues.apache.org/jira/browse/HDFS-6302
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: HDFS XAttrs (HDFS-2006)
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>             Fix For: HDFS XAttrs (HDFS-2006)
>
>         Attachments: HDFS-6302.1.patch, HDFS-6302.patch
>
>
> XAttr is based on INode feature(HDFS-5284).
> Persisting XAttrs in fsimage and edit log is handled by HDFS-6301.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to