[
https://issues.apache.org/jira/browse/HDFS-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988898#comment-13988898
]
Yi Liu commented on HDFS-6298:
------------------------------
Andrew, thanks a lot for review and comments.
{quote}
Let's restore System.err in an @After clause in TestXAttrCommands. The
System.err stuff could be done in a @BeforeClass and @AfterClass if you want.
We should reset errContent in an @After too.
{quote}
OK. Let's restore system.err and reset errContent in an @After clause.
{quote}
Higher-level comment, is TestXAttrCommands even necessary when we have the XML
infrastructure? It seems like we could fold those into the XML test instead.
{quote}
I see your meaning. TestXAttrCommands is a more general test for fs shell
input, doesn't rely on any file system. I'm inclined to keep them, could we?
{quote}
Maybe add tests for removing/getting a non-existent xattr, help commands?
{quote}
OK. Let's add them.
> XML based End-to-End test for getfattr and setfattr commands
> ------------------------------------------------------------
>
> Key: HDFS-6298
> URL: https://issues.apache.org/jira/browse/HDFS-6298
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client, namenode
> Affects Versions: HDFS XAttrs (HDFS-2006)
> Reporter: Uma Maheswara Rao G
> Assignee: Yi Liu
> Fix For: HDFS XAttrs (HDFS-2006)
>
> Attachments: HDFS-6298.patch
>
>
> This JIRA to add test cases with CLI
--
This message was sent by Atlassian JIRA
(v6.2#6252)
