[
https://issues.apache.org/jira/browse/HDFS-6340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989705#comment-13989705
]
Kihwal Lee commented on HDFS-6340:
----------------------------------
Good catch! I think we can start with {{false}} as the initial value and use
the simple assignment instead of AND operation. After all, the last result
must be up-to-date. But there is another problem.
{{nn.isStandbyState()}} is not protected from HA state transitions. We could
create a {{FSNamesystem}} method that acquires its read lock and checks the
datanode storage staleness (calling down to {{BlockManager}}) and the HA state.
This is preferred since we want to avoid making {{BlockManager}} lock
{{FSNameSystem}}. If we do this, we don't have to check the individual results
from {{processReport()}}.
> DN can't finalize upgarde
> -------------------------
>
> Key: HDFS-6340
> URL: https://issues.apache.org/jira/browse/HDFS-6340
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Affects Versions: 2.4.0
> Reporter: Rahul Singhal
> Priority: Blocker
> Attachments: HDFS-6340-branch-2.4.0.patch
>
>
> I upgraded a (NN) HA cluster from 2.2.0 to 2.4.0. After I issued the
> '-finalizeUpgarde' command, NN was able to finalize the upgrade but DN
> couldn't (I waited for the next block report).
> I think I have found the problem to be due to HDFS-5153. I will attach a
> proposed fix.
--
This message was sent by Atlassian JIRA
(v6.2#6252)