[ 
https://issues.apache.org/jira/browse/HDFS-6133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990874#comment-13990874
 ] 

Daryn Sharp commented on HDFS-6133:
-----------------------------------

Upon a cursory review, I think the patch is promising.  I wonder if favored 
nodes and pinning should be combined, but it stands to reason that if you want 
specific nodes that you probably don't want the blocks to move.  Plus it's 
least disruptive to apis.  I haven't crawled through the favored node code, but 
I'm assuming the NN may not grant all the requested/favored nodes?  If yes, 
does it make sense to only pin the blocks on the favored nodes that were 
granted?

A small quick question: Do you need to use a Boolean instead a primitive 
boolean?  

> Make Balancer support exclude specified path
> --------------------------------------------
>
>                 Key: HDFS-6133
>                 URL: https://issues.apache.org/jira/browse/HDFS-6133
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: balancer, namenode
>            Reporter: zhaoyunjiong
>            Assignee: zhaoyunjiong
>         Attachments: HDFS-6133-1.patch, HDFS-6133.patch
>
>
> Currently, run Balancer will destroying Regionserver's data locality.
> If getBlocks could exclude blocks belongs to files which have specific path 
> prefix, like "/hbase", then we can run Balancer without destroying 
> Regionserver's data locality.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to