[
https://issues.apache.org/jira/browse/HDFS-5381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13991569#comment-13991569
]
Hadoop QA commented on HDFS-5381:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12643677/HDFS-5381.002.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/6843//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6843//console
This message is automatically generated.
> ExtendedBlock#hashCode should use both blockId and block pool ID
> ----------------------------------------------------------------
>
> Key: HDFS-5381
> URL: https://issues.apache.org/jira/browse/HDFS-5381
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: federation
> Affects Versions: 2.3.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-5381.001.patch, HDFS-5381.002.patch
>
>
> {{ExtendedBlock#hashCode}} contains both a block pool ID and a block ID. The
> {{equals}} function checks both. However, {{hashCode}} only uses block ID.
> Since HDFS-4645, block IDs are now allocated sequentially. This means that
> there will be a lot of hash collisions when federation is in use. We should
> use both block ID and block pool ID in {{hashCode}} to prevent this.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
