[
https://issues.apache.org/jira/browse/HDFS-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992775#comment-13992775
]
Uma Maheswara Rao G edited comment on HDFS-6357 at 5/8/14 2:12 PM:
-------------------------------------------------------------------
Thanks a lot, Yi for the review!
I have formatted the line which is crossing 80 chars. Thanks for noticing.
I have noticed another issue that, currently we used setXattrOp for both remove
and set Xattrs operations. But we intent to persist only for setXattrs op as we
are planned implement retrycache only for setXattr. So, for avoiding
persistence of removeXattrs rpcid related bytes, we need modifications in
SetXattrsOP to handle both cases in single class.
Otherwise we endup persisting zero length clientid etc. Let's wait for the
commit of HDFS-6346, so, that automatically issue will be solved as HDFS-6346
might propose to have separate op for removeXattr.
was (Author: umamaheswararao):
Thanks a lot, Yi for the review!
I have formatted the line which is crossing 80 chars. Thanks for noticing.
I have noticed another issue that, currently we used setXattrOp for both remove
and set Xattrs operations. But we intent to persist only for setXattrs op as we
are planned implement retrycache only for setXattr. So, for avoiding
persistence of removeXattrs rpcid related bytes, we need modifications in
SetXattrsOP to handle both cases in single class.
Otherwise we endup persisting zero length clientid etc. So, I will wait for the
commit of HDFS-6346, so, that automatically issue will be solved as HDFS-6346
might propose to have separate op for removeXattr.
> SetXattr should persist rpcIDs for handling Namenode restart and HA
> -------------------------------------------------------------------
>
> Key: HDFS-6357
> URL: https://issues.apache.org/jira/browse/HDFS-6357
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: HDFS XAttrs (HDFS-2006)
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-6357.patch, HDFS-6357.patch
>
>
> SetXattr should persist rpcIDs for handling restart Namenode and HA scenarios
--
This message was sent by Atlassian JIRA
(v6.2#6252)
