[ https://issues.apache.org/jira/browse/HDFS-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999261#comment-13999261 ]
Arpit Agarwal commented on HDFS-6362: ------------------------------------- The FindBugs warning looks invalid since the patch does not touch FsAclPermissions. bq. org.apache.hadoop.hdfs.protocol.FsAclPermission doesn't override org.apache.hadoop.fs.permission.FsPermission.equals(Object) Also we don't need new tests as per my earlier comment. I will commit this shortly. > InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID > ----------------------------------------------------------------------- > > Key: HDFS-6362 > URL: https://issues.apache.org/jira/browse/HDFS-6362 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 2.4.0 > Reporter: Arpit Agarwal > Assignee: Arpit Agarwal > Priority: Blocker > Fix For: 3.0.0, 2.4.1 > > Attachments: HDFS-6362.01.patch, HDFS-6362.02.patch, > HDFS-6362.03.patch, HDFS-6362.04.patch > > > {{InvalidateBlocks}} must consistently use datanodeUuid as the key. e.g. add > and remove functions use datanode UUID and storage ID. -- This message was sent by Atlassian JIRA (v6.2#6252)