[
https://issues.apache.org/jira/browse/HDFS-6438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004312#comment-14004312
]
Tsz Wo Nicholas Sze commented on HDFS-6438:
-------------------------------------------
Patch looks good. Some minor comments:
- In the public delete(..) method in NamenodeWebHdfsMethods, pass the
snapshotName parameter to init(..).
- In the private delete(..) method in NamenodeWebHdfsMethods, reuse np for the
DELETE case.
- The following should "a HTTP DELETE request".
{code}
+** {Delete Snapshot}
+
+ * Submit a HTTP PUT request.
{code}
> DeleteSnapshot should be a DELETE request in WebHdfs
> ----------------------------------------------------
>
> Key: HDFS-6438
> URL: https://issues.apache.org/jira/browse/HDFS-6438
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: webhdfs
> Affects Versions: 2.5.0
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-6438.000.patch, HDFS-6438.001.patch
>
>
> We add 3 snapshot related APIs into WebHdfs in HDFS-6432, among which
> DeleteSnapshot should be a DELETE request instead of PUT. This jira aims to
> fix this and update the WebHdfs document.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
