[
https://issues.apache.org/jira/browse/HDFS-6461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011704#comment-14011704
]
Andrew Wang commented on HDFS-6461:
-----------------------------------
Hey, one more real nitty comment: we like to keep lines to max 80 characters. I
use this Eclipse formatter (works in IDEA too) to do it for me:
https://github.com/cloudera/blog-eclipse/blob/master/hadoop-format.xml
Another minor comment, we also typically name our patches something like
"HDFS-6461.2.patch" with a version number so it's easier to download the right
one. Thanks James!
> Time.now -> Time.monotonicNow in DataNode.java#shutDown
> -------------------------------------------------------
>
> Key: HDFS-6461
> URL: https://issues.apache.org/jira/browse/HDFS-6461
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Affects Versions: 2.5.0
> Reporter: James Thomas
> Assignee: James Thomas
> Priority: Trivial
> Fix For: 2.5.0
>
> Attachments: HDFS-6461.patch, HDFS-6461.patch
>
>
> The system time can move around for various reasons, so we convert to
> monotonicNow to ensure greater accuracy when computing a duration in this
> method.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
