[
https://issues.apache.org/jira/browse/HDFS-6424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014232#comment-14014232
]
Jing Zhao commented on HDFS-6424:
---------------------------------
The new looks good to me. Just nits:
# "TestStandbyIsHot" should be "TestStandbyBlockManagement"?
{code}
+ protected static final Log LOG = LogFactory.getLog(
+ TestStandbyIsHot.class);
{code}
# How about just using LOG.info instead of System.err?
{code}
+ System.err.println("==================================");
{code}
# Do we also want to add a pending deletion count check between the edit log
roll and the heartbeat triggering call? In that way we can cover the scenario
for block deletion, while unknown block scenario can be covered by the check in
the current patch. It's not a necessary change, since we already disable SBN
sending block deletion command to DN thus checking in the end can guarantee the
correctness. But it may be nice to have it to make the test more complete. You
can decide whether you want to add this extra check.
+1 after addressing the comments.
> blockReport doesn't need to invalidate blocks on SBN
> ----------------------------------------------------
>
> Key: HDFS-6424
> URL: https://issues.apache.org/jira/browse/HDFS-6424
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Ming Ma
> Assignee: Ming Ma
> Attachments: HDFS-6424-2.patch, HDFS-6424.patch
>
>
> After the fix in https://issues.apache.org/jira/browse/HDFS-6178,
> blockManager no longer compute pending replication work on SBN. As part of
> that, it also stop removing items from invalidateBlocks.
> blocks can still be added to invalidateBlocks on SBN as part of blockReport.
> As a result, the PendingDeletionBlocks metrics will keep going up on SBN.
> To fix that, we don't need to add blocks to invalidateBlocks during
> blockReport for SBN.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
