[
https://issues.apache.org/jira/browse/HDFS-6392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HDFS-6392:
-------------------------------
Attachment: HDFS-6392.patch.2
Hi Andrew,
I made all of the changes that you suggested below. A couple of comments:
bq. Can we make the key and IV final, and avoid the need for synchronized on
the getters in DFSInputStream?
I don't think we can because we set them in
DFSInputStream#fetchLocatedBlocksAndGetLastBlockLength
The other two similar key/iv's I did make final.
bq. General comment, sprinkling the same hardcoding everywhere is not as
nice as say, defining it statically once somewhere, makes it easier to undo the
hardcode later
I moved this to HdfsConstants.
bq. Indentation in PBHelper#convert was changed from two indents to one, but
two indents is our code style.
I wasn't sure what you meant here. It looks like the existing was 4 spaces and
I moved it to 2 spaces. In any case, I undid this change so it doesn't appear
in the new diff.
bq. Let's undo the changes in BlockManager and FSDirectory, they're just
adding TODOs and whitespace
I removed the TODOs and whitespace changes, but other changes popped into these
files (ctor changes).
> Wire crypto streams for encrypted files in DFSClient
> -----------------------------------------------------
>
> Key: HDFS-6392
> URL: https://issues.apache.org/jira/browse/HDFS-6392
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode, security
> Reporter: Alejandro Abdelnur
> Assignee: Charles Lamb
> Attachments: HDFS-6392.1.patch, HDFS-6392.patch.2
>
>
> When the DFS client gets a key material and IV for a file being
> opened/created, it should wrap the stream with a crypto stream initialized
> with the key material and IV.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
