[jira] [Commented] (HDFS-6392) Wire crypto streams for encrypted files in DFSClient

[Yi Liu (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-6392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018399#comment-14018399
 ] 

Yi Liu commented on HDFS-6392:
------------------------------

Thanks Charles, very good and really close, one small nit, after that +1.

{code}
public class HdfsDataOutputStream extends FSDataOutputStream {
-  public HdfsDataOutputStream(DFSOutputStream out, FileSystem.Statistics stats,
+  public HdfsDataOutputStream(OutputStream out, FileSystem.Statistics stats,
       long startPosition) throws IOException {
     super(out, stats, startPosition);
   }
 
-  public HdfsDataOutputStream(DFSOutputStream out, FileSystem.Statistics stats
+  public HdfsDataOutputStream(OutputStream out, FileSystem.Statistics stats
       ) throws IOException {
     this(out, stats, 0L);
   }
{code}
I think you forgot to revert this modification, since it’s not necessary in 
your current patch.


>  Wire crypto streams for encrypted files in DFSClient
> -----------------------------------------------------
>
>                 Key: HDFS-6392
>                 URL: https://issues.apache.org/jira/browse/HDFS-6392
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode, security
>            Reporter: Alejandro Abdelnur
>            Assignee: Charles Lamb
>         Attachments: HDFS-6392.1.patch, HDFS-6392.2.patch, HDFS-6392.3.patch, 
> HDFS-6392.4.patch, HdfsDataInputStream-HdfsDataOutputStream_crypto.1.diff, 
> HdfsDataInputStream-HdfsDataOutputStream_crypto.diff
>
>
> When the DFS client gets a key material and IV for a file being 
> opened/created, it should wrap the stream with a crypto stream initialized 
> with the key material and IV.



--
This message was sent by Atlassian JIRA
(v6.2#6252)