[
https://issues.apache.org/jira/browse/HDFS-6500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020918#comment-14020918
]
Hadoop QA commented on HDFS-6500:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12648819/h6500_20140607.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7058//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7058//console
This message is automatically generated.
> Snapshot shouldn't be removed silently after renaming to an existing snapshot
> -----------------------------------------------------------------------------
>
> Key: HDFS-6500
> URL: https://issues.apache.org/jira/browse/HDFS-6500
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: snapshots
> Affects Versions: 2.4.0
> Reporter: Junping Du
> Assignee: Tsz Wo Nicholas Sze
> Priority: Blocker
> Attachments: h6500_20140607.patch
>
>
> Assume you have two snapshots for /dir: s1, s2, when you do "hdfs dfs
> -renameSnapshot /dir s2 s1" which means you want to rename s2 to s1. It will
> cause s2 been dropped silently and s1 still keep the previous one. This is
> very confusing and easily cause wrong operation.
> The right behavior should be providing a warning to remind user that the
> target name is already existed and do nothing. If user do want to overlap s1,
> he should add some option (i.e. "-f") or delete s1 first.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
