[
https://issues.apache.org/jira/browse/HDFS-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14026678#comment-14026678
]
Chris Nauroth commented on HDFS-6395:
-------------------------------------
{code}
if (xAttr.getNameSpace() == XAttr.NameSpace.USER ||
xAttr.getNameSpace() == XAttr.NameSpace.TRUSTED) {
{code}
Minor nit-pick: this piece of logic is duplicated. It might be worthwhile to
put this in a helper method or possibly add an {{isUserVisible}} method on the
{{NameSpace}} enum to document the intent.
I agree with Andrew's feedback about removing these prints. If it's too tricky
to log warnings during loading right now, then let's proceed with the other
valuable changes in this patch. We can always revisit the logging later if
needed.
Thank you for working on this, Yi.
> Assorted improvements to xattr limit checking
> ---------------------------------------------
>
> Key: HDFS-6395
> URL: https://issues.apache.org/jira/browse/HDFS-6395
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 3.0.0
> Reporter: Andrew Wang
> Assignee: Yi Liu
> Attachments: HDFS-6395.patch
>
>
> It'd be nice to print messages during fsimage and editlog loading if we hit
> either the # of xattrs per inode or the xattr size limits.
> We should also consider making the # of xattrs limit only apply to the user
> namespace, or to each namespace separately, to prevent users from locking out
> access to other namespaces.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
