[
https://issues.apache.org/jira/browse/HDFS-6521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029911#comment-14029911
]
Charles Lamb commented on HDFS-6521:
------------------------------------
Eddy,
Looks good. A picked up a few other things (sorry, I should have gotten them
the first time).
There's a whitespace-only change right after public class. In general, I sense
that these kinds of changes are ever-so-slightly frowned upon because they
cause code churn and eventual merge conflicts. [~andrew.wang] can check me on
that.
// TODO: will eventually auto-wrap the text, but this matches the expected
// output for the hdfs tests...
Is the comment above still relevant?
I'd give it a +1, but I can't.
> Improve the readability of 'hadoop fs -help'
> --------------------------------------------
>
> Key: HDFS-6521
> URL: https://issues.apache.org/jira/browse/HDFS-6521
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: tools
> Affects Versions: 2.5.0
> Reporter: Lei Xu
> Assignee: Lei Xu
> Priority: Minor
> Fix For: 2.5.0
>
> Attachments: HDFS-6521.000.patch, HDFS-6521.001.patch,
> HDFS-6521.002.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> 'hadoop fs -help` displays help informations with numbers of different
> formats.
> This patch borrows the format used in `hdfs cacheadmin -help`: all options
> are formatted by using org.apache.hadoop.tools.TableListing.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
