[ 
https://issues.apache.org/jira/browse/HDFS-6518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14032869#comment-14032869
 ] 

Colin Patrick McCabe commented on HDFS-6518:
--------------------------------------------

Yeah, I agree that we need to take the FSN read lock there.  +1.  Thanks 
Yongjun.

> TestCacheDirectives#testExceedsCapacity should take FSN read lock when 
> accessing pendingCached list
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-6518
>                 URL: https://issues.apache.org/jira/browse/HDFS-6518
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.5.0
>            Reporter: Yongjun Zhang
>            Assignee: Andrew Wang
>         Attachments: HDFS-6518.001.patch
>
>
> Observed from 
> https://builds.apache.org/job/PreCommit-HDFS-Build/7080//testReport/
> Test 
> org.apache.hadoop.hdfs.server.namenode.TestCacheDirectives.testExceedsCapacity
> fails intermittently
> {code}
> Failing for the past 1 build (Since Failed#7080 )
> Took 7.3 sec.
> Stacktrace
> java.lang.AssertionError: null
>       at org.junit.Assert.fail(Assert.java:86)
>       at org.junit.Assert.assertTrue(Assert.java:41)
>       at org.junit.Assert.assertTrue(Assert.java:52)
>       at 
> org.apache.hadoop.hdfs.server.namenode.TestCacheDirectives.checkPendingCachedEmpty(TestCacheDirectives.java:1416)
>       at 
> org.apache.hadoop.hdfs.server.namenode.TestCacheDirectives.testExceedsCapacity(TestCacheDirectives.java:1437)
> {code}
> A second run with the same code is successful,
> https://builds.apache.org/job/PreCommit-HDFS-Build/7082//testReport/
> Running it locally is also successful.
>  HDFS-6257 mentioned about possible race, maybe the issue is still there.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to