[ https://issues.apache.org/jira/browse/HDFS-6545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033128#comment-14033128 ]
Jing Zhao commented on HDFS-6545: --------------------------------- Yeah, looks like we do not need to do an extra checkpoint while finalizing rolling upgrade. The current patch looks good to me. One minor comment is that for HA setup we do not need to call logSync since rollEditLog already covers the sync part. > Finalizing rolling upgrade can make NN unavailable for a long duration > ---------------------------------------------------------------------- > > Key: HDFS-6545 > URL: https://issues.apache.org/jira/browse/HDFS-6545 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: 2.4.0 > Reporter: Kihwal Lee > Priority: Critical > Attachments: HDFS-6545.patch > > > In {{FSNamesystem#finalizeRollingUpgrade()}}, {{saveNamespace()}} is directly > called. For name nodes with a big name space, it can take minutes to save a > new fsimage. -- This message was sent by Atlassian JIRA (v6.2#6252)