[
https://issues.apache.org/jira/browse/HDFS-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033244#comment-14033244
]
Andrew Wang commented on HDFS-6386:
-----------------------------------
Hi Charles, thanks for the rev, I did an actually thorough review this time:
* Unused logRetryCache parameter being passed to FSDir
* Some things that aren't being used in this patch: setFileKeyMaterial,
getFileEncryptionInfo, setFileEncryptionAttributes, parentEncryptionKeyId,
changes in FSN#getFileInfo and FSN#startFileInternal, pc in createEZInt and
deleteEZInt, isSuperUser in listEncryptionZones.
* createEZInt, if it's already in an EZ, could include the EZ in the exception
text.
* listEZs, can we just use {{Lists.newArrayList(encryptionZones.values())}}?
* listEZ, we can move logAuditEvent outside of the critical section
> HDFS Encryption Zones
> ---------------------
>
> Key: HDFS-6386
> URL: https://issues.apache.org/jira/browse/HDFS-6386
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode, security
> Reporter: Alejandro Abdelnur
> Assignee: Charles Lamb
> Fix For: fs-encryption (HADOOP-10150 and HDFS-6134)
>
> Attachments: HDFS-6386.012.patch, HDFS-6386.4.patch,
> HDFS-6386.5.patch, HDFS-6386.6.patch, HDFS-6386.8.patch
>
>
> Define the required security xAttributes for directories and files within an
> encryption zone and how they propagate to children. Implement the logic to
> create/delete encryption zones.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
