[
https://issues.apache.org/jira/browse/HDFS-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033532#comment-14033532
]
Hadoop QA commented on HDFS-6551:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12650728/HDFS-6551.000.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7143//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7143//console
This message is automatically generated.
> Rename with OVERWRITE option may throw NPE when the target file/directory is
> a reference INode
> ----------------------------------------------------------------------------------------------
>
> Key: HDFS-6551
> URL: https://issues.apache.org/jira/browse/HDFS-6551
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-6551.000.patch
>
>
> The following steps can reproduce the NPE:
> 1. create a snapshot on /
> 2. move /foo/file1 to /bar/
> 3. rename /foo/file2 to /bar/file1 with the OVERWRITE option
> After step 2, /bar/file1 is a DstReference inode. In step 3,
> FSDirectory#unprotectedRename first detaches the DstReference inode from the
> WithCount inode, then it still calls the cleanSubtree method of the
> corresponding INodeFile instance, which triggers the NPE. We should follow
> the same logic in FSDirectory#unprotectedDelete which skips the cleanSubtree
> call in this scenario.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
