[ 
https://issues.apache.org/jira/browse/HDFS-6418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037946#comment-14037946
 ] 

Tsz Wo Nicholas Sze commented on HDFS-6418:
-------------------------------------------

I agree with Suresh and Jing that DFSConfigKeys is not a public API so that it 
should not be used outside HDFS.  On the other hand, the conf property key is a 
public API.  For example,
{code}
//DFSConfigKeys.java
  public static final String  DFS_BLOCK_SIZE_KEY = "dfs.blocksize";
{code}
DFS_BLOCK_SIZE_KEY is not a public API.  Projects outside HDFS should not use 
DFSConfigKeys.DFS_BLOCK_SIZE_KEY.  However, the value "dfs.blocksize" is a 
public API as it is defined in hdfs-default.xml.

In the long term, Slider should eliminate referencing DFSConfigKeys.  In the 
short term, I don't mind adding back the previously removed constants as 
deprecated.  Sounds good?

> Regression: DFS_NAMENODE_USER_NAME_KEY missing in trunk
> -------------------------------------------------------
>
>                 Key: HDFS-6418
>                 URL: https://issues.apache.org/jira/browse/HDFS-6418
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 3.0.0, 2.5.0
>            Reporter: Steve Loughran
>            Assignee: Tsz Wo Nicholas Sze
>
> Code i have that compiles against HADOOP 2.4 doesn't build against trunk as 
> someone took away {{DFSConfigKeys.DFS_NAMENODE_USER_NAME_KEY}} -apparently in 
> HDFS-6181.
> I know the name was obsolete, but anyone who has compiled code using that 
> reference -rather than cutting and pasting in the string- is going to find 
> their code doesn't work.
> More subtly: that will lead to a link exception trying to run that code on a 
> 2.5+  cluster.
> This is a regression: the old names need to go back in, even if they refer to 
> the new names and are marked as deprecated



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to