[
https://issues.apache.org/jira/browse/HDFS-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038165#comment-14038165
]
Tsz Wo Nicholas Sze commented on HDFS-4667:
-------------------------------------------
Patch looks good. Some comments:
- Need to document how rename is captured in the diff report.
- Add a getRenameEntry(inodeId) to SnapshotDiffInfo.
- I suggest move SnapshotDiffInfo out from INodeDirectorySnapshottable since it
is getting big. We should also refactor some other snapshot diff report code
out. We may do it separately.
- The patch does not apply any more. Need to update it.
> Capture renamed files/directories in snapshot diff report
> ---------------------------------------------------------
>
> Key: HDFS-4667
> URL: https://issues.apache.org/jira/browse/HDFS-4667
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Reporter: Jing Zhao
> Assignee: Binglin Chang
> Attachments: HDFS-4667.002.patch, HDFS-4667.002.patch,
> HDFS-4667.003.patch, HDFS-4667.demo.patch, HDFS-4667.v1.patch,
> getfullname-snapshot-support.patch
>
>
> Currently in the diff report we only show file/dir creation, deletion and
> modification. After rename with snapshots is supported, renamed file/dir
> should also be captured in the diff report.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
