[ 
https://issues.apache.org/jira/browse/HDFS-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039209#comment-14039209
 ] 

Arpit Agarwal commented on HDFS-6579:
-------------------------------------

Is this ppc64 Linux?

The patch looks fine to me. Just a suggestion, there is OS type detection in 
Shell.Java. e.g. see {{Shell.getOSType}}. Perhaps you can extend that to 
include your target platform and add a static helper similar to 
{{Shell.WINDOWS}}. Not the ideal location to have this logic and there was a 
proposal to abstract out platform-specific checks into a separate module but 
for now we can at least keep them in one location.

> TestSocketIOWithTimeout#testSocketIOWithTimeout fails on Power PC 
> ------------------------------------------------------------------
>
>                 Key: HDFS-6579
>                 URL: https://issues.apache.org/jira/browse/HDFS-6579
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.1.0-beta, 2.0.4-alpha, 2.2.0, 2.3.0, 2.4.0
>            Reporter: Jinghui Wang
>             Fix For: 2.4.1
>
>         Attachments: HDFS-6579.patch
>
>
> SocketOutputStream closes its writer if it's partial written. But on PPC, 
> after writing for some time, buf.capacity still equals buf.remaining. The 
> reason might be what's written on PPC is buffered,so the buf.remaining will 
> not change till a flush.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to