[
https://issues.apache.org/jira/browse/HDFS-6580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039376#comment-14039376
]
Hadoop QA commented on HDFS-6580:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12651704/patch_cadc3030359f6c317e46d43c9f7ef61c5576a872.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.TestFSImageWithSnapshot
org.apache.hadoop.hdfs.TestLease
org.apache.hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
org.apache.hadoop.hdfs.server.namenode.snapshot.TestSnapshot
org.apache.hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots
org.apache.hadoop.hdfs.TestDFSClientRetries
org.apache.hadoop.hdfs.server.namenode.TestFsck
org.apache.hadoop.hdfs.server.namenode.TestAuditLogs
org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
org.apache.hadoop.hdfs.server.namenode.snapshot.TestINodeFileUnderConstructionWithSnapshot
org.apache.hadoop.hdfs.TestDatanodeBlockScanner
org.apache.hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks
org.apache.hadoop.hdfs.TestFileAppend4
org.apache.hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
org.apache.hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality
org.apache.hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes
org.apache.hadoop.hdfs.TestReplication
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7190//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7190//console
This message is automatically generated.
> 2 internal APIs in FSNamesystem use raw dir.getFileInfo() to
> getAuditFileInfo()
> -------------------------------------------------------------------------------
>
> Key: HDFS-6580
> URL: https://issues.apache.org/jira/browse/HDFS-6580
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Zhilei Xu
> Assignee: Zhilei Xu
> Labels: patch
> Attachments: patch_cadc3030359f6c317e46d43c9f7ef61c5576a872.txt
>
>
> In FSNamesystem.java, getAuditFileInfo() is the canonical way to get file
> info for auditing purpose. getAuditFileInfo() returns null when auditing is
> disabled, and calls dir.getFileInfo() when auditing is enabled.
> 2 internal APIs, startFileInt() and mkdirsInt() mistakenly use the raw
> dir.getFileInfo() to get file info for auditing. Should change to
> getAuditFileInfo().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
