[ 
https://issues.apache.org/jira/browse/HDFS-6580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhilei Xu updated HDFS-6580:
----------------------------

    Description: 
In FSNamesystem.java, getAuditFileInfo() is the canonical way to get file info 
for auditing purpose. getAuditFileInfo() returns null when auditing is 
disabled, and calls dir.getFileInfo() when auditing is enabled.

One internal APIs, mkdirsInt() mistakenly use the raw dir.getFileInfo() to get 
file info for auditing. Should change to getAuditFileInfo().

Note that another internal API, startFileInt() uses dir.getFileInfo() 
correctly, because the returned file stat is returned out.



  was:
In FSNamesystem.java, getAuditFileInfo() is the canonical way to get file info 
for auditing purpose. getAuditFileInfo() returns null when auditing is 
disabled, and calls dir.getFileInfo() when auditing is enabled.

One internal APIs, mkdirsInt() mistakenly use the raw dir.getFileInfo() to get 
file info for auditing. Should change to getAuditFileInfo().




> FSNamesystem.mkdirsInt uses raw dir.getFileInfo() to getAuditFileInfo()
> -----------------------------------------------------------------------
>
>                 Key: HDFS-6580
>                 URL: https://issues.apache.org/jira/browse/HDFS-6580
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Zhilei Xu
>            Assignee: Zhilei Xu
>              Labels: patch
>         Attachments: patch_c89bff2bb7a06bb2b0c66a85acbd5113db6b0526.txt
>
>
> In FSNamesystem.java, getAuditFileInfo() is the canonical way to get file 
> info for auditing purpose. getAuditFileInfo() returns null when auditing is 
> disabled, and calls dir.getFileInfo() when auditing is enabled.
> One internal APIs, mkdirsInt() mistakenly use the raw dir.getFileInfo() to 
> get file info for auditing. Should change to getAuditFileInfo().
> Note that another internal API, startFileInt() uses dir.getFileInfo() 
> correctly, because the returned file stat is returned out.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to