[
https://issues.apache.org/jira/browse/HDFS-6580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039643#comment-14039643
]
Hadoop QA commented on HDFS-6580:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12651757/patch_c89bff2bb7a06bb2b0c66a85acbd5113db6b0526.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.datanode.TestBPOfferService
org.apache.hadoop.hdfs.TestCrcCorruption
org.apache.hadoop.hdfs.TestFileAppend4
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7195//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7195//console
This message is automatically generated.
> FSNamesystem.mkdirsInt uses raw dir.getFileInfo() to getAuditFileInfo()
> -----------------------------------------------------------------------
>
> Key: HDFS-6580
> URL: https://issues.apache.org/jira/browse/HDFS-6580
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Zhilei Xu
> Assignee: Zhilei Xu
> Labels: patch
> Attachments: patch_c89bff2bb7a06bb2b0c66a85acbd5113db6b0526.txt
>
>
> In FSNamesystem.java, getAuditFileInfo() is the canonical way to get file
> info for auditing purpose. getAuditFileInfo() returns null when auditing is
> disabled, and calls dir.getFileInfo() when auditing is enabled.
> One internal APIs, mkdirsInt() mistakenly use the raw dir.getFileInfo() to
> get file info for auditing. Should change to getAuditFileInfo().
> Note that another internal API, startFileInt() uses dir.getFileInfo()
> correctly, because the returned file stat is returned out.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
