[
https://issues.apache.org/jira/browse/HDFS-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039694#comment-14039694
]
Hadoop QA commented on HDFS-6585:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12651794/patch_ab60af58e03b323dd4b18d32c4def1f008b98822.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:red}-1 javac{color}. The applied patch generated 1262 javac
compiler warnings (more than the trunk's current 1259 warnings).
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 4 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/7197//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/7197//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Javac warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/7197//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7197//console
This message is automatically generated.
> INodesInPath.resolve is called multiple times in FSNamesystem.setPermission
> ---------------------------------------------------------------------------
>
> Key: HDFS-6585
> URL: https://issues.apache.org/jira/browse/HDFS-6585
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Zhilei Xu
> Assignee: Zhilei Xu
> Labels: patch
> Attachments: patch_ab60af58e03b323dd4b18d32c4def1f008b98822.txt
>
>
> Most of the APIs (both internal and external) in FSNamesystem calls
> INodesInPath.resolve() to get the list of INodes corresponding to a file
> path. Usually one API will call resolve() multiple times and that's a waste
> of time.
> This issue particularly refers to FSNamesystem.setPermission, which calls
> resolve() twice indirectly: one from checkOwner(), another from
> dir.setPermission().
> Should save the result of resolve(), and use it whenever possible throughout
> the lifetime of an API call, instead of making new resolve() calls.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
