[
https://issues.apache.org/jira/browse/HDFS-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039728#comment-14039728
]
Yongjun Zhang commented on HDFS-6578:
-------------------------------------
HI [~arpitagarwal], thanks for your comments earlier. Yes, that's what I
thought. Including these three piece of info should be helpful.
I just uploaded a patch, including the comments I wanted to add for HDFS-6577.
Thanks for review!
> add toString method to DatanodeStorage etc for easier debugging
> ---------------------------------------------------------------
>
> Key: HDFS-6578
> URL: https://issues.apache.org/jira/browse/HDFS-6578
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Yongjun Zhang
> Assignee: Yongjun Zhang
> Attachments: HDFS-6578.001.patch
>
>
> It seems to be nice to add a toString() method for DatanodeStorage class, so
> we can print out its key info easier while doing debuging.
> Another thing is, in the end of BlockManager#processReport, there is the
> following message,
> {code}
> blockLog.info("BLOCK* processReport: from storage " +
> storage.getStorageID()
> + " node " + nodeID + ", blocks: " + newReport.getNumberOfBlocks()
> + ", processing time: " + (endTime - startTime) + " msecs");
> return !node.hasStaleStorages();
> {code}
> We could add node.hasStaleStorages() to the log, and possibly replace
> storage.getSorateID() with the suggested storage.toString().
> Any comments? thanks.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
