[ https://issues.apache.org/jira/browse/HDFS-6593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14041339#comment-14041339 ]
Haohui Mai commented on HDFS-6593: ---------------------------------- The patch looks good to me. Is it possible to refactor the code of {{FSNameSystem.getSnapshotDiffReport}} in this patch as well, so that {{SnapshotDiffInfo}} can be declared as a package-local class? > Move SnapshotDiffInfo out of INodeDirectorySnapshottable > -------------------------------------------------------- > > Key: HDFS-6593 > URL: https://issues.apache.org/jira/browse/HDFS-6593 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode, snapshots > Reporter: Jing Zhao > Assignee: Jing Zhao > Priority: Minor > Attachments: HDFS-6593.000.patch > > > Per discussion in HDFS-4667, we can move SnapshotDiffInfo out of > INodeDirectorySnapshottable as an individual class. -- This message was sent by Atlassian JIRA (v6.2#6252)