[ 
https://issues.apache.org/jira/browse/HDFS-6387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042706#comment-14042706
 ] 

Colin Patrick McCabe commented on HDFS-6387:
--------------------------------------------

{code}
+  private static TableListing getOptionDescriptionListing() {
+    final TableListing listing = new TableListing.Builder()
+    .addField("").addField("", true)
+    .wrapWidth(MAX_LINE_WIDTH).hideHeaders().build();
+    return listing;
+  }
{code}

Need to fix indentation

{code}
+      try {
+        final List<EncryptionZone> ezs = dfs.listEncryptionZones();
+        for (EncryptionZone ez : ezs) {
+          System.out.println(ez);
+        }
{code}

I'd prefer using a {{TableListing}} built up with getters here rather than 
using {{EncryptionZone#toString}}

+1 once those are addressed

> HDFS CLI admin tool for creating & deleting an encryption zone
> --------------------------------------------------------------
>
>                 Key: HDFS-6387
>                 URL: https://issues.apache.org/jira/browse/HDFS-6387
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode, security
>            Reporter: Alejandro Abdelnur
>            Assignee: Charles Lamb
>         Attachments: HDFS-6387.002.patch, HDFS-6387.003.patch, 
> HDFS-6387.1.patch
>
>
> CLI admin tool to create/delete an encryption zone in HDFS.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to