[
https://issues.apache.org/jira/browse/HDFS-6601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14046205#comment-14046205
]
Jing Zhao commented on HDFS-6601:
---------------------------------
The patch looks good to me. +1. Thanks [~kihwal]!
> Issues in finalizing rolling upgrade when there is a layout version change
> --------------------------------------------------------------------------
>
> Key: HDFS-6601
> URL: https://issues.apache.org/jira/browse/HDFS-6601
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Kihwal Lee
> Assignee: Kihwal Lee
> Priority: Blocker
> Attachments: HDFS-6601.patch
>
>
> After HDFS-6545, we have noticed a couple of issues.
> - The storage dir's VERSION file is not properly updated. This becomes a
> problem when there is a layout version change. We can have the finalization
> do {{storage.writeAll()}}
> - {{OP_ROLLING_UPGRADE_FINALIZE}} cannot be replayed, once the corresponding
> {{OP_ROLLING_UPGRADE_START}} is consumed and a new fsimage is created (e.g.
> rollback image). On restart, NN terminates complaining it can't finalize
> something that it didn't start. We can make NN ignore
> {{OP_ROLLING_UPGRADE_FINALIZE}} if no rolling upgrade is in progress.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
