[
https://issues.apache.org/jira/browse/HDFS-6614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HDFS-6614:
--------------------------------
Target Version/s: 3.0.0, 2.5.0
Affects Version/s: 2.5.0
Hadoop Flags: Reviewed
+1 for the patch. I ran this multiple times, and it passed. I'll commit this.
BTW, I did discover that the new {{testHedgedReadLoopTooManyTimes}} test is
failing on my Windows VM on the assertion for the loop count. I suspect this
isn't a Windows problem, but rather a race condition still lingering in the
code. Windows tends to schedule threads just differently enough that we see
the effects of race conditions that weren't visible under the Linux scheduler.
We can fix this as a separate issue.
{code}
FAILURE! - in org.apache.hadoop.hdfs.TestPread
testHedgedReadLoopTooManyTimes(org.apache.hadoop.hdfs.TestPread) Time elapsed:
0.918 sec <<< FAILURE!
java.lang.AssertionError: expected:<3> but was:<2>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:743)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:555)
at org.junit.Assert.assertEquals(Assert.java:542)
at
org.apache.hadoop.hdfs.TestPread.testHedgedReadLoopTooManyTimes(TestPread.java:328)
{code}
> shorten TestPread run time with a smaller retry timeout setting
> ---------------------------------------------------------------
>
> Key: HDFS-6614
> URL: https://issues.apache.org/jira/browse/HDFS-6614
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 3.0.0, 2.5.0
> Reporter: Liang Xie
> Assignee: Liang Xie
> Priority: Minor
> Attachments: HDFS-6614.txt
>
>
> Just notice logs like this from TestPread:
> DFS chooseDataNode: got # 3 IOException, will wait for 9909.622860072854 msec
> so i tried to set a smaller retry window value.
> Before patch:
> T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.hdfs.TestPread
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 154.812 sec -
> in org.apache.hadoop.hdfs.TestPread
> After the change:
> T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.hdfs.TestPread
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 131.724 sec -
> in org.apache.hadoop.hdfs.TestPread
--
This message was sent by Atlassian JIRA
(v6.2#6252)
