[ 
https://issues.apache.org/jira/browse/HDFS-6493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051875#comment-14051875
 ] 

Hudson commented on HDFS-6493:
------------------------------

SUCCESS: Integrated in Hadoop-trunk-Commit #5824 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/5824/])
HDFS-6493. Change dfs.namenode.startup.delay.block.deletion to second instead 
of millisecond. Contributed by Juan Yu. (wang: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1607732)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/InvalidateBlocks.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingInvalidateBlock.java


> Change dfs.namenode.startup.delay.block.deletion to second instead of 
> millisecond
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-6493
>                 URL: https://issues.apache.org/jira/browse/HDFS-6493
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Juan Yu
>            Assignee: Juan Yu
>            Priority: Trivial
>             Fix For: 2.5.0
>
>         Attachments: HDFS-6493.001.patch
>
>
> Based on the discussion in https://issues.apache.org/jira/browse/HDFS-6186, 
> the delay will be at least 30 minutes or even hours. it's not very user 
> friendly to use milliseconds when it's likely measured in hours.
> I suggest to make the following change
> 1. change the unit of this config to second
> 2. rename the config key from "dfs.namenode.startup.delay.block.deletion.ms" 
> to "dfs.namenode.startup.delay.block.deletion.sec"
> 3. add the default value to hdfs-default.xml, what's the reasonable value, 30 
> minutes, one hour?



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to