[ 
https://issues.apache.org/jira/browse/HDFS-6614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053967#comment-14053967
 ] 

Chris Nauroth commented on HDFS-6614:
-------------------------------------

Thanks for the addendum patch.  In my environments, I found that it was only 
necessary to set {{DFS_CLIENT_RETRY_WINDOW_BASE}} to 0 (one-line patch).  The 
other changes for creating a new {{DFSClient}} and reordering the 
{{Mockito#reset}} call seem to be unnecessary.  Can we remove those changes and 
commit just the one-line addendum patch, or are you finding that those changes 
are required in your environment?

bq. Did your Windows VM run on a SSD or similar fast storage ? 

Actually, it was the opposite.  This is very slow virtualized storage on top of 
HDD, so I/O generally is slower for me when I'm working on my Windows VM.  
Another potential factor is timer resolution on Windows.  I filed HDFS-6631 to 
track fixing this part separately.

> shorten TestPread run time with a smaller retry timeout setting
> ---------------------------------------------------------------
>
>                 Key: HDFS-6614
>                 URL: https://issues.apache.org/jira/browse/HDFS-6614
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: test
>    Affects Versions: 3.0.0, 2.5.0
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>            Priority: Minor
>             Fix For: 3.0.0, 2.5.0
>
>         Attachments: HDFS-6614-addmium.txt, HDFS-6614.txt
>
>
> Just notice logs like this from TestPread:
> DFS chooseDataNode: got # 3 IOException, will wait for 9909.622860072854 msec
> so i tried to set a smaller retry window value.
> Before patch:
>  T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.hdfs.TestPread
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 154.812 sec - 
> in org.apache.hadoop.hdfs.TestPread
> After the change:
>  T E S T S
> -------------------------------------------------------
> Running org.apache.hadoop.hdfs.TestPread
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 131.724 sec - 
> in org.apache.hadoop.hdfs.TestPread



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to