[
https://issues.apache.org/jira/browse/HDFS-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056991#comment-14056991
]
Jing Zhao commented on HDFS-6643:
---------------------------------
The patch looks pretty good to me. But it looks like the fields of
LongBitFormat do not need to be public (they are only used inside of
LongBitFormat)?
> Refactor INodeFile.HeaderFormat and
> INodeWithAdditionalFields.PermissionStatusFormat
> ------------------------------------------------------------------------------------
>
> Key: HDFS-6643
> URL: https://issues.apache.org/jira/browse/HDFS-6643
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Priority: Minor
> Attachments: h6643_20140708.patch, h6643_20140708b.patch
>
>
> The use of them are very similar. We should change INodeFile.HeaderFormat to
> enum and refactor them for code reuse.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
