[
https://issues.apache.org/jira/browse/HDFS-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14057532#comment-14057532
]
Hudson commented on HDFS-6618:
------------------------------
SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1827 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1827/])
HDFS-6618. FSNamesystem#delete drops the FSN lock between removing INodes from
the tree and deleting them from the inode map (kihwal via cmccabe) (cmccabe:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1609380)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
*
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
> FSNamesystem#delete drops the FSN lock between removing INodes from the tree
> and deleting them from the inode map
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-6618
> URL: https://issues.apache.org/jira/browse/HDFS-6618
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Kihwal Lee
> Assignee: Kihwal Lee
> Priority: Blocker
> Fix For: 2.5.0
>
> Attachments: HDFS-6618.AbstractList.patch,
> HDFS-6618.inodeRemover.patch, HDFS-6618.inodeRemover.v2.patch,
> HDFS-6618.patch, HDFS-6618.simpler.patch
>
>
> After HDFS-6527, we have not seen the edit log corruption for weeks on
> multiple clusters until yesterday. Previously, we would see it within 30
> minutes on a cluster.
> But the same condition was reproduced even with HDFS-6527. The only
> explanation is that the RPC handler thread serving {{addBlock()}} was
> accessing stale parent value. Although nulling out parent is done inside the
> {{FSNamesystem}} and {{FSDirectory}} write lock, there is no memory barrier
> because there is no "synchronized" block involved in the process.
> I suggest making parent volatile.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
