[
https://issues.apache.org/jira/browse/HDFS-6631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HDFS-6631:
--------------------------------
Hadoop Flags: Reviewed
Thanks, Liang, for the really nice analysis! The timings you chose in this
patch make a lot of sense too when we consider that the default timer
resolution on Windows is 15.6 ms. The old logic used just a 1 ms delta.
Introducing a separate wait greater than 15.6 ms makes sense, which is what
this patch does. I ran the test many times on both Mac and Windows, and I saw
no failures.
+1 for the patch. I'll commit this.
> TestPread#testHedgedReadLoopTooManyTimes fails intermittently.
> --------------------------------------------------------------
>
> Key: HDFS-6631
> URL: https://issues.apache.org/jira/browse/HDFS-6631
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs-client, test
> Affects Versions: 3.0.0, 2.5.0
> Reporter: Chris Nauroth
> Assignee: Liang Xie
> Attachments: HDFS-6631.txt,
> org.apache.hadoop.hdfs.TestPread-output.txt
>
>
> {{TestPread#testHedgedReadLoopTooManyTimes}} fails intermittently. It looks
> like a race condition on counting the expected number of loop iterations. I
> can repro the test failure more consistently on Windows.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
