[
https://issues.apache.org/jira/browse/HDFS-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062224#comment-14062224
]
Uma Maheswara Rao G commented on HDFS-6490:
-------------------------------------------
Hi [~clamb], I have reviewed the patch. Please find the comments below.
Patch need update with latest code
I think now we are passing keyid from outside to createNewKey.
In the case nameserviceID null we can use assume non federated cluster and use
DFS_NAMENODE_RPC_ADDRESS_KEY?
seems like when you have path ends with '/', you want to pass last char, that
means again '/'. so can we use directly '/' instead of substring?
sb.append(src.endsWith("/") ? "/" : src); --> sb.append(src.endsWith("/") ?
'/' : src);
sb.append("/"); --> sb.append('/');
> Fix the keyid format for generated keys in FSNamesystem.createEncryptionZone
> -----------------------------------------------------------------------------
>
> Key: HDFS-6490
> URL: https://issues.apache.org/jira/browse/HDFS-6490
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode, security
> Affects Versions: fs-encryption (HADOOP-10150 and HDFS-6134)
> Reporter: Charles Lamb
> Assignee: Charles Lamb
> Attachments: HDFS-6490.001.patch
>
>
> FSNamesystem.createEncryptionZone needs to create key ids with the format
> hdfs://HOST:PORT/<pathOfEZ>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
