[
https://issues.apache.org/jira/browse/HDFS-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Lamb updated HDFS-6490:
-------------------------------
Attachment: HDFS-6490.002.patch
Thanks for the review [~umamaheswararao].
bq. Patch need update with latest code
Yes, this was a rather old patch. I've rebased it.
bq. In the case nameserviceID null we can use assume non federated cluster and
use DFS_NAMENODE_RPC_ADDRESS_KEY?
I'm confused. Isn't that what DFSUtil.getNamenodeNameServiceId is doing when
nameserviceId is initialized?
bq. seems like when you have path ends with '/', you want to pass last char,
that means again '/'. so can we use directly '/' instead of substring?
sb.append(src.endsWith("/") ? "/" : src); --> sb.append(src.endsWith("/") ? '/'
: src);
I've fixed this. It now takes the path from 0 up to the end (without the
trailing /).
bq. sb.append("/"); --> sb.append('/');
ok.
> Fix the keyid format for generated keys in FSNamesystem.createEncryptionZone
> -----------------------------------------------------------------------------
>
> Key: HDFS-6490
> URL: https://issues.apache.org/jira/browse/HDFS-6490
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode, security
> Affects Versions: fs-encryption (HADOOP-10150 and HDFS-6134)
> Reporter: Charles Lamb
> Assignee: Charles Lamb
> Attachments: HDFS-6490.001.patch, HDFS-6490.002.patch
>
>
> FSNamesystem.createEncryptionZone needs to create key ids with the format
> hdfs://HOST:PORT/<pathOfEZ>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
