[ 
https://issues.apache.org/jira/browse/HDFS-6680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064949#comment-14064949
 ] 

Hadoop QA commented on HDFS-6680:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12656261/h6680_20140716.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.tools.TestDFSAdminWithHA

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/7369//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7369//console

This message is automatically generated.

> BlockPlacementPolicyDefault does not choose favored nodes correctly
> -------------------------------------------------------------------
>
>                 Key: HDFS-6680
>                 URL: https://issues.apache.org/jira/browse/HDFS-6680
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>         Attachments: h6680_20140714.patch, h6680_20140716.patch
>
>
> In one of the chooseTarget(..) methods, it tries all the favoredNodes to 
> chooseLocalNode(..).  It expects chooseLocalNode to return null if the local 
> node is not a good target.  Unfortunately, chooseLocalNode will fallback to 
> chooseLocalRack but not returning null.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to