[ 
https://issues.apache.org/jira/browse/HDFS-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068935#comment-14068935
 ] 

Colin Patrick McCabe commented on HDFS-6707:
--------------------------------------------

Good find, Yongjun.

Parsing the output of this shell command is definitely worrisome.  It has been 
the source of bunch of bugs in the past.  Unfortunately, even if we came up 
with a JNI method to do this, not everyone would use it, so here we are.

Can we do this by skipping over the first code point following the comma, 
rather than by looking for a specific quote type?  That seems more flexible in 
case there are any more wacky variants.

> Intermittent failure of Symlink tests 
> TestSymlinkLocalFSFileContext,TestSymlinkLocalFSFileSystem 
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-6707
>                 URL: https://issues.apache.org/jira/browse/HDFS-6707
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: symlinks
>    Affects Versions: 2.5.0
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>         Attachments: HDFS-6707.001.patch, HDFS-6707.002.dbg.patch, 
> HDFS-6707.003.dbg.patch, HDFS-6707.004.patch
>
>
> Symlink tests failure happened from time to time,
> https://builds.apache.org/job/PreCommit-HDFS-Build/7383//testReport/
> https://builds.apache.org/job/PreCommit-HDFS-Build/7376/testReport/
> {code}
> Failed
> org.apache.hadoop.fs.TestSymlinkLocalFSFileContext.testDanglingLink
> Failing for the past 1 build (Since Failed#7376 )
> Took 83 ms.
> Error Message
> Path 
> file:/home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-common-project/hadoop-common/target/test/data/RtGBheUh4y/test1/linkToFile
>  is not a symbolic link
> Stacktrace
> java.io.IOException: Path 
> file:/home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-common-project/hadoop-common/target/test/data/RtGBheUh4y/test1/linkToFile
>  is not a symbolic link
>       at org.apache.hadoop.fs.FileStatus.getSymlink(FileStatus.java:266)
>       at 
> org.apache.hadoop.fs.TestSymlinkLocalFS.testDanglingLink(TestSymlinkLocalFS.java:163)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>       at java.lang.reflect.Method.invoke(Method.java:597)
>       at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
>       at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>       at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
>       at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>       at 
> org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
> Standard Output
> 2014-07-17 23:31:37,770 WARN  fs.FileUtil (FileUtil.java:symLink(829)) - 
> Command 'ln -s 
> /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-common-project/hadoop-common/target/test/data/RtGBheUh4y/test1/file
>  
> /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-common-project/hadoop-common/target/test/data/RtGBheUh4y/test2/linkToFile'
>  failed 1 with: ln: failed to create symbolic link 
> '/home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-common-project/hadoop-common/target/test/data/RtGBheUh4y/test2/linkToFile':
>  No such file or directory
> 2014-07-17 23:31:38,109 WARN  fs.FileUtil (FileUtil.java:symLink(829)) - 
> Command 'ln -s 
> /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-common-project/hadoop-common/target/test/data/RtGBheUh4y/test1/file
>  
> /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-common-project/hadoop-common/target/test/data/RtGBheUh4y/test1/linkToFile'
>  failed 1 with: ln: failed to create symbolic link 
> '/home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-common-project/hadoop-common/target/test/data/RtGBheUh4y/test1/linkToFile':
>  File exists
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to