[
https://issues.apache.org/jira/browse/HDFS-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069760#comment-14069760
]
Arpit Agarwal edited comment on HDFS-6702 at 7/22/14 3:20 AM:
--------------------------------------------------------------
Hi [~szetszwo],
# For {{writeBlock}}, why do we pass both {{targetStorageTypes[0]}} and
{{targetStorageTypes}}? Wouldn't it be sufficient to just pass
targetStorageTypes?
# DatanodeProtocol.proto: I got confused about {{BlockCommandProto}}. It has
{{repeated StorageTypesProto targetStorageTypes}} which itself has repeated
{{StorageTypeProto}} as member. Can we just make this {{repeated
StorageTypeProto targetStorageTypes}} and remove the {{StorageTypesProto}}
message?
was (Author: arpitagarwal):
Hi [~szetszwo],
#for {{writeBlock}}, why do we pass both {{targetStorageTypes[0]}} and
{{targetStorageTypes}}? Wouldn't it be sufficient to just pass
targetStorageTypes?
# DatanodeProtocol.proto: I got confused about {{BlockCommandProto}}. It has
{{repeated StorageTypesProto targetStorageTypes}} which itself has repeated
{{StorageTypeProto}} as member. Can we just make this {{repeated
StorageTypeProto targetStorageTypes}} and remove the {{StorageTypesProto}}
message?
> DFSClient should create blocks using StorageType
> -------------------------------------------------
>
> Key: HDFS-6702
> URL: https://issues.apache.org/jira/browse/HDFS-6702
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode, hdfs-client
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Attachments: h6702_20140719.patch, h6702_20140721.patch,
> h6702_20140721b.patch
>
>
> When DFSClient asks NN for a new block (via addBlock), NN returns a
> LocatedBlock with storage type information. However, DFSClient does not use
> StorageType to create blocks with DN. As a result, the block replicas could
> possibly be created with a different storage type.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
