[
https://issues.apache.org/jira/browse/HDFS-6247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14075093#comment-14075093
]
Charles Lamb commented on HDFS-6247:
------------------------------------
[~vinayrpet],
In general this looks good. A few nits:
BlockReceiver.java:
At least one line exceeds the 80 char width.
In receiveBlock, you changed the indentation which causes unnecessary code
churn.
It's my understanding that general patching protocol is that you should have
each new patch file be named with a sequential number. Hence,
HDFS-6247.001.patch
HDFS-6247.002.patch
...
You'll need to get another reviewer on this. I'm not a committer, but I play
one on TV.
> Avoid timeouts for replaceBlock() call by sending intermediate responses to
> Balancer
> ------------------------------------------------------------------------------------
>
> Key: HDFS-6247
> URL: https://issues.apache.org/jira/browse/HDFS-6247
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer, datanode
> Affects Versions: 2.4.0
> Reporter: Vinayakumar B
> Assignee: Vinayakumar B
> Attachments: HDFS-6247.patch, HDFS-6247.patch, HDFS-6247.patch,
> HDFS-6247.patch, HDFS-6247.patch
>
>
> Currently there is no response sent from target Datanode to Balancer for the
> replaceBlock() calls.
> Since the Block movement for balancing is throttled, complete block movement
> will take time and this could result in timeout at Balancer, which will be
> trying to read the status message.
>
> To Avoid this during replaceBlock() call in in progress Datanode can send
> IN_PROGRESS status messages to Balancer to avoid timeouts and treat
> BlockMovement as failed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
