[
https://issues.apache.org/jira/browse/HDFS-6757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076505#comment-14076505
]
Haohui Mai commented on HDFS-6757:
----------------------------------
Thanks Colin for the review.
bq. ... Perhaps we should just make internalReleaseLease take an INode ID?
Agree. However, the issue here is that {{internalReleaseLease}} eventually
calls {{closeFile}}, which logs the full path in the edit log. We probably need
to change {{closeFile}} to log inodeids instead of full paths before making the
proposed change. Do you think whether it is okay to address it in a follow-up
jira?
> Simplify lease manager with INodeID
> -----------------------------------
>
> Key: HDFS-6757
> URL: https://issues.apache.org/jira/browse/HDFS-6757
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-6757.000.patch, HDFS-6757.001.patch,
> HDFS-6757.002.patch
>
>
> Currently the lease manager records leases based on path instead of inode
> ids. Therefore, the lease manager needs to carefully keep track of the path
> of active leases during renames and deletes. This can be a non-trivial task.
> This jira proposes to simplify the logic by tracking leases using inodeids
> instead of paths.
--
This message was sent by Atlassian JIRA
(v6.2#6252)