[
https://issues.apache.org/jira/browse/HDFS-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076561#comment-14076561
]
Brandon Li commented on HDFS-6451:
----------------------------------
The patch looks pretty good to me. Some minor comments:
1. checkIOException() might be better called mapError/mapErrorStatus/mapStatus
or something similar
2. it would be nice to add some unit tests
> NFS should not return NFS3ERR_IO for AccessControlException
> ------------------------------------------------------------
>
> Key: HDFS-6451
> URL: https://issues.apache.org/jira/browse/HDFS-6451
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: nfs
> Reporter: Brandon Li
> Attachments: HDFS-6451.patch
>
>
> As [~jingzhao] pointed out in HDFS-6411, we need to catch the
> AccessControlException from the HDFS calls, and return NFS3ERR_PERM instead
> of NFS3ERR_IO for it.
> Another possible improvement is to have a single class/method for the common
> exception handling process, instead of repeating the same exception handling
> process in different NFS methods.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
