[ 
https://issues.apache.org/jira/browse/HDFS-6739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077130#comment-14077130
 ] 

Tsz Wo Nicholas Sze commented on HDFS-6739:
-------------------------------------------

Thanks Jing for reviewing the patch.
For #1, the import fix is required since the package of DatanodeStorageProto is 
changed.
{code}
-import 
org.apache.hadoop.hdfs.protocol.proto.DatanodeProtocolProtos.DatanodeStorageProto;
...
+import org.apache.hadoop.hdfs.protocol.proto.HdfsProtos.DatanodeStorageProto;
{code}

I will fix #2 and #3.

> Besides, do we need to consider the scenario that the 
> getDatanodeStorageReport response size exceeds the max response size? ...

This a good point.  Let's fix it in a separated JIRA as you suggested.

> Add getDatanodeStorageReport to ClientProtocol
> ----------------------------------------------
>
>                 Key: HDFS-6739
>                 URL: https://issues.apache.org/jira/browse/HDFS-6739
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client, namenode
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>         Attachments: h6739_20140724.patch
>
>
> ClientProtocol has a getDatanodeReport(..) methods for retrieving datanode 
> report from namenode.  However, there is no way to get datanode storage 
> report.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to