[ 
https://issues.apache.org/jira/browse/HDFS-6778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078640#comment-14078640
 ] 

Andrew Wang commented on HDFS-6778:
-----------------------------------

This is a nice improvement! It'll reduce duplication and ease any updates we 
need to make.

* In some places, it'd be nice to keep a little more. For example, in setXAttr, 
we could keep the "namespace.name" example but still keep it generic, i.e.

bq. The name must be prefixed with the namespace followed by "." For example, 
"user.attr".

Another example of something we might want to keep (noticed you kept it 
sometimes and not in others):

{noformat}
-   * Only those xattrs for which the logged-in user has permissions to view
-   * are returned.
{noformat}

* I'd like it if it said "HDFS extended attributes user documentation".
* ClientProtocol also has similar redundancy we can remove, devs can refer to 
the user documentation too :)

Thanks Charles :)

> The extended attributes avadoc should simply refer to the HDFS Extended 
> Attributes doc
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-6778
>                 URL: https://issues.apache.org/jira/browse/HDFS-6778
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Charles Lamb
>            Assignee: Charles Lamb
>         Attachments: HDFS-6778.001.patch
>
>
> The javadoc for Extended Attributes is mostly duplicated in a handful of 
> files. Rather than trying to make it consistent in all of those files, let's 
> simply refer to the actual extended attributes doc.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to