[
https://issues.apache.org/jira/browse/HDFS-6692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079049#comment-14079049
]
Stephen Chu commented on HDFS-6692:
-----------------------------------
Hi Andrew, nice tests.
Nits:
Can remove the concatenation in the following? {{"Too many retries because of "
+ "encryption zone operations"}}
Line with the following comment goes over 80 char: {{* Tests the retry logic in
startFile. We release the lock while generating an}}
One additional test that can be added is attempting to create an encryption
zone on a parent of an encryption zone.
A minor additional test is checking that {{HdfsAdmin#listEncryptionZones}}
succeeds / throws reasonable exception in {{testCreateEZWithNoProvider}}.
I can add these tests later, too, if you prefer.
> Add more HDFS encryption tests
> ------------------------------
>
> Key: HDFS-6692
> URL: https://issues.apache.org/jira/browse/HDFS-6692
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: security
> Affects Versions: fs-encryption (HADOOP-10150 and HDFS-6134)
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-6692.001.patch
>
>
> Now that we have the basic pieces in place for encryption, it's a good time
> to look at our test coverage and add new tests.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
